fix: make result field optional in ResultMessage #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result field can be nil for error messages which contain an errors array instead. This change: - Removes result from @enforce_keys - Updates type spec to allow nil - Removes result from required_fields validation - Fixes String.Chars implementation to handle nil result - Displays errors when result is nil Fixes handling of error result messages from the CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
resultfield can benilfor error messages which contain anerrorsarray instead. This PR fixes the handling of error result messages from the CLI.Changes
resultfrom@enforce_keys(no longer required)nil:result: String.t() | nilresultfrom required_fields validationString.Charsprotocol implementation:nilresult with errors arraynilresult without errorsResultMessageinstead ofResult)Test Plan
errorsarray are properly handledThis fixes issues when the CLI returns error results that don't have a
resultfield.